F1: starter sets and module manager #10
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
schaefera/utStudyBIble#10
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Phase 1 item (docs/01-pathway.md, docs/04-features.md F1, docs/08-module-presets.md).
core/src/tasks/); a half-finished set continues on the next start.presets/*.tomlplus a CI job that checks each preset against the live CrossWire index.Builds on the resumable download from spike S4. Depends on the database from #11 for task state.
Part 1/2 merged in #26:
presets/*.toml)Nothing is visible in the app yet. Follow-ups: #28 (416 on resume), #29 (preset-check reporting).
Part 2, still open: the qt glue and QML for the module manager and the first-run starter-set picker; wiring the runner; a top-level menu entry (with #30); measuring click size and PSS. Phone QC for F1 comes after part 2.
Part 2 is split into three PRs, shipped one at a time:
presets/, with the licence and size of each module. One tap downloads it, with progress. A half-finished set continues on the next start. The e2e cases download from a local repository served in the sandbox, never from CrossWire.Phone QC for F1 comes after 2c.
Part 2a is merged in #71 (
766cf41), with Review-Confidence 85.766cf41is installed. It starts in 296 ms, restores KJV Ruth 3 and saves on suspend.🤖 Generated with Claude Code
Part 2b (module manager) merged in PR #82 (
9caf6ed). The owner's phone check passed. Follow-ups: #83, #84, #85, #86, #87, #88. This issue stays open for part 2c (import).Part 2c (import) merged in PR #90 (
5e6a0ed), Review-Confidence 70. The review audit caught one more defect, now fixed: a package whoseDataPathwas another installed module's folder replaced that module's files. Every install now refuses it. Follow-ups: #92, #93, #94, #95, #96, #97, #98.F1 phone QC. Merged main
5e6a0edis installed on the phone (11:52). Holding the reading pane's footer should showmain@5e6a0ed. This issue stays open until you sign off.First run. These steps clear the app's data, so its modules, place and settings go. Do them when you're ready, then launch from the launcher:
adb shell rm -rf /home/phablet/.local/share/utstudybible.schaefera /home/phablet/.cache/utstudybible.schaefera /home/phablet/.config/utstudybible.schaeferaModule manager.
Import (passed on your earlier check of #90; re-check on this build):
Anything off → a comment here, or a new issue for anything bigger.
Comments:
ℹ️ The "Choose your bibles" should be removed, as the setup step is rather clear, and isn't just for bibles.
ℹ️ The remove button in the module deletion modal popup should probably be red, as all destructive operations really should be for UX purposes, but this can be redone after a UI/UX design document has been created.
ℹ️ Hitting refresh after the completion of an action (such as installing a module or bible) should clear the previous notice. Additionally, the location for the text seems a bit crammed in. Should be resolved after the UI/UX design documents are made.
Otherwise all checks are good.
F1 signed off on main
5e6a0ed(comment 2134): steps 1–10 pass; step 11 (optional) is covered by the core testan_import_killed_mid_download_goes_on_from_its_part.From the phone log during the check:
list(on start-up) and the connectivity service'sPrivateinterface (offline greying still works through the public status).Follow-ups from your comments: #99 (drop "Choose your bibles", Could), #100 (show "Retrying…" during the wait, Could); red destructive buttons and the Modules notice (clear on Refresh, spacing) are noted on #95 for the design. Closing.