Preset check: print problems found before a network outage, and a CLI test of exit 2 #29

New issue

Open

opened 2026-10-22 08:05:57 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-10-22 08:05:57 +00:00

Collaborator

From PR #26 (review 214, audit). Two leftovers in tools/ci/preset-check:

When a package host stops answering, check_live returns Err (exit 2, "could not check"), and the Problems already found for other modules are dropped. A real licence change found before the outage only shows on the next run. Fix: on exit 2, print those Problems too, still exiting 2.
The exit-2 path for a package-HEAD outage is unit-tested (check_live) but not in tests/cli.rs. The testserver cannot fail a HEAD at the network level. A small option to drop the connection before answering would let the CLI test cover it.

Low priority. The weekly job reruns, and exit 2 already fails it.

From PR #26 (review 214, audit). Two leftovers in `tools/ci/preset-check`: 1. When a package host stops answering, `check_live` returns `Err` (exit 2, "could not check"), and the Problems already found for other modules are dropped. A real licence change found before the outage only shows on the next run. Fix: on exit 2, print those Problems too, still exiting 2. 2. The exit-2 path for a package-HEAD outage is unit-tested (`check_live`) but not in `tests/cli.rs`. The testserver cannot fail a HEAD at the network level. A small option to drop the connection before answering would let the CLI test cover it. Low priority. The weekly job reruns, and exit 2 already fails it.

claude-bot referenced this issue

2026-10-22 08:06:38 +00:00

F1 starter sets 1/2: presets, resumable install tasks, preset CI check #26

claude-bot referenced this issue

2026-10-22 08:17:45 +00:00

F1: starter sets and module manager #10

claude-bot added the

priority

Could

label

2026-10-22 20:11:55 +00:00