schaefera/utStudyBIble
Watch
1
0
Fork
You've already forked utStudyBIble
 0
Code Issues 62 Pull requests Projects Releases Packages Wiki Activity Actions

Remove the night mode setting? #85

New issue
Closed
opened 2026-10-27 17:18:29 +00:00 by claude-bot · 0 comments
claude-bot commented 2026-10-27 17:18:29 +00:00
Collaborator

From the phone check of PR #82, the owner said: "I'm still not really sold on the night mode concept; I would honestly remove it in a separate issue."

Proposal: drop the separate Night setting and follow the system theme (light or dark) only. That also makes #41's "dimming night mode" part unnecessary, so check #41's scope when doing this.

What changes:

  • the setting in Settings, and its stored value (a migration if it is in the schema; otherwise just ignore the old key);
  • the Theme code paths;
  • the e2e cases that toggle night (display-settings, display-settings-kill) and their shots;
  • the user manual and docs/04 if night mode is listed there;
  • the translations (cargo make i18n).

Owner decides whether to keep or remove it; priority is my proposal.

From the phone check of PR #82, the owner said: "I'm still not *really* sold on the night mode concept; I would honestly remove it in a separate issue." **Proposal:** drop the separate Night setting and follow the system theme (light or dark) only. That also makes #41's "dimming night mode" part unnecessary, so check #41's scope when doing this. What changes: - the setting in Settings, and its stored value (a migration if it is in the schema; otherwise just ignore the old key); - the Theme code paths; - the e2e cases that toggle night (`display-settings`, `display-settings-kill`) and their shots; - the user manual and docs/04 if night mode is listed there; - the translations (`cargo make i18n`). Owner decides whether to keep or remove it; priority is my proposal.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/e2e-pytest
feat/redesign-about
feat/redesign-first-start
feat/redesign-menus
feat/redesign-modules
feat/redesign-chooser
feat/redesign-settings
feat/lectern-rebrand
feat/lectern-menu
feat/lectern-type-footer
feat/lectern-light-ground
feat/lectern-palette
fix/sheet-theme
fix/unknown-v11n
i18n/part-2
fix/marker-colour
ci/module-cache
docs/mockup-check
fix/log-line-atomic
fix/sheet-scroll
feat/13-6d-tsk
feat/13-6c-markers
feat/13-6b-refs
feat/13-6a-notes-refs
fix/install-416-restart
fix/e2e-menu-retry
fix/back-one-transaction
feat/paragraph-starts
feat/verse-look
fix/empty-cipherkey
fix/mem-check-noise
chore/claude-config
ci/main-runs
refactor/shared-controls
feat/module-import
feat/offline-install-icons
feat/module-manager
tools/e2e-shots
fix/strongs-datapath
phase1/switch-bible
phase1/first-run
phase1/red-letters
phase1/e2e
phase1/quick-settings
ci/s3-sccache
phase1/picker-height
phase1/gettext
phase1/picker-history
phase1/build-info
phase1/core-layout
No results found.
Labels
Clear labels   
priority
Could
 MoSCoW: nice to have, done when time allows

  
priority
Must
 MoSCoW: the release isn't viable without it

  
priority
Should
 MoSCoW: important, but the release works without it

  
priority
Won't
 MoSCoW: not this release (kept for later)

  
type
Bug

No labels
priority
Could
priority
Must
priority
Should
priority
Won't
type
Bug
Milestone
Clear milestone
No items
No milestone
v0.1 — reader
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
schaefera/utStudyBIble#85
No description provided.