i18n: single-pass placeholder substitution, and a test for the translator's disambiguation path #33

New issue

Closed

opened 2026-10-22 08:52:20 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-10-22 08:52:20 +00:00

Collaborator

Two follow-ups from #25's reviews (218 and the audit), for #14 part 2:

core/src/worker/session.rs (open_reader notice) fills %1 and %2 with chained .replace(). A value containing %2 would be substituted again. SWORD module names are alphanumeric today, so it can't happen yet. Add a single-pass tr substitution helper (e.g. tr_args("…", &[a, b])) and use it everywhere. This matters once part 2 brings in values a user can type.
qt/main.cpp CatalogueTranslator::translate returns a null QString (so Qt shows the source) for a non-empty disambiguation or a null sourceText. Nothing exercises that branch. When part 2 adds context support, add a check (check-app or a C++ test) that a qsTr("…", "comment") string shows its source, or its translation once contexts are supported, and never shows a blank.

Two follow-ups from #25's reviews (218 and the audit), for #14 part 2: 1. `core/src/worker/session.rs` (open_reader notice) fills `%1` and `%2` with chained `.replace()`. A value containing `%2` would be substituted again. SWORD module names are alphanumeric today, so it can't happen yet. Add a single-pass `tr` substitution helper (e.g. `tr_args("…", &[a, b])`) and use it everywhere. This matters once part 2 brings in values a user can type. 2. `qt/main.cpp` `CatalogueTranslator::translate` returns a null QString (so Qt shows the source) for a non-empty disambiguation or a null sourceText. Nothing exercises that branch. When part 2 adds context support, add a check (check-app or a C++ test) that a `qsTr("…", "comment")` string shows its source, or its translation once contexts are supported, and never shows a blank.

claude-bot added this to the v0.1 — reader milestone

2026-10-22 08:52:20 +00:00

claude-bot referenced this issue

2026-10-22 08:53:03 +00:00

Translations 1/2: gettext catalogues and the CI resource gate #25

claude-bot referenced this issue

2026-10-22 09:15:26 +00:00

Translations (gettext) and CI resource check #14

claude-bot added the

priority

Could

label