schaefera/utStudyBIble

Watch

Fork 0

Add Bibles: ticks at the row's edge, clear of the text #73

Merged

claude-bot merged 1 commit from fix/starter-tick-align into main

2026-10-23 14:43:45 +00:00

claude-bot commented

2026-10-23 14:04:11 +00:00

Collaborator

What

In the Bible chooser's "+" page (the starter page), the tick on each Bible row now sits at the right edge (left in RTL). Before, the Suru style, which is UT's default, centred it over the description text.
Cause: the row's CheckDelegate had no text, and Suru centres the indicator when text is empty. The fix sets text to the module name. It is not drawn, because the custom contentItem replaces it, and it also gives the tick an accessible name.
Refs #70.

Blast radius

Tier: leaf
Trunk paths touched: none (qml/pages/StarterPage.qml, +4 lines)
Testing tier: standard
Gate / rollback: revert the commit; no flag, no data change.

Proof

cargo make app-docker (QML lint, clippy, -Werror build, clang-tidy, mem-check): "== [72s] done"; normal profile peak PSS 148738 kB (budget 165000 kB).
E2E_CASES="add-bible starter-install" cargo make e2e-docker: "PASS add-bible (17s)", "PASS starter-install (7s)", "e2e: 2 passed, 0 failed, 0 skipped". e2e uses the Default style, where the bug cannot show, so this only shows no regression.
CI on dd67c9e: rust, audit, app, e2e, click all success.
Suru before/after screenshots (Xvfb, QT_QUICK_CONTROLS_STYLE=Suru) were made locally: the tick moves from mid-row to the right edge. They could not be attached here (the MCP has no upload). Installed-state rows were not captured, only ticked ones.
Not tried on the phone.

Review

Reviewer: fresh-context code-review at medium (review 255 on dd67c9e): 0 findings, 0 fixed, 0 declined, 0 deferred, 0 fixed after the delta review, 0 left open. Medium, not audited (leaf).
Review-Confidence: not scored (leaf).

Confidence by part

The text: line: high. The Suru source shows the exact line that positions the indicator.
Installed-state rows: medium, not screenshotted.

Owner try-list (phone)

Open the Bible chooser's "+": ticks sit at the right edge, with no text under them.
A long description wraps clear of the tick.

## What In the Bible chooser's "+" page (the starter page), the tick on each Bible row now sits at the right edge (left in RTL). Before, the Suru style, which is UT's default, centred it over the description text. Cause: the row's CheckDelegate had no `text`, and Suru centres the indicator when `text` is empty. The fix sets `text` to the module name. It is not drawn, because the custom contentItem replaces it, and it also gives the tick an accessible name. Refs #70. ## Blast radius **Tier:** leaf **Trunk paths touched:** none (qml/pages/StarterPage.qml, +4 lines) **Testing tier:** standard **Gate / rollback:** revert the commit; no flag, no data change. ## Proof - `cargo make app-docker` (QML lint, clippy, -Werror build, clang-tidy, mem-check): "== [72s] done"; normal profile peak PSS 148738 kB (budget 165000 kB). - `E2E_CASES="add-bible starter-install" cargo make e2e-docker`: "PASS add-bible (17s)", "PASS starter-install (7s)", "e2e: 2 passed, 0 failed, 0 skipped". e2e uses the Default style, where the bug cannot show, so this only shows no regression. - CI on dd67c9e: rust, audit, app, e2e, click all success. - Suru before/after screenshots (Xvfb, QT_QUICK_CONTROLS_STYLE=Suru) were made locally: the tick moves from mid-row to the right edge. They could not be attached here (the MCP has no upload). Installed-state rows were not captured, only ticked ones. - Not tried on the phone. ## Review **Reviewer:** fresh-context `code-review` at medium (review 255 on dd67c9e): 0 findings, 0 fixed, 0 declined, 0 deferred, 0 fixed after the delta review, 0 left open. Medium, not audited (leaf). **Review-Confidence:** not scored (leaf). ## Confidence by part - The `text:` line: high. The Suru source shows the exact line that positions the indicator. - Installed-state rows: medium, not screenshotted. ## Owner try-list (phone) - Open the Bible chooser's "+": ticks sit at the right edge, with no text under them. - A long description wraps clear of the tick.

claude-bot added 1 commit

2026-10-23 14:04:11 +00:00

Add Bibles: ticks at the row's edge, clear of the text (#70 )

CI / rust (pull_request) Successful in 7m43s

Details

CI / audit (pull_request) Successful in 21s

Details

CI / app (pull_request) Successful in 4m15s

Details

CI / e2e (pull_request) Successful in 6m24s

Details

CI / click (pull_request) Successful in 2m53s

Details

dd67c9e92f

The module rows are CheckDelegates with a custom contentItem and no text.
The Suru style puts the indicator mid-row when the text is empty
(x: text ? width - ... : leftPadding + (availableWidth - width) / 2),
over the labels. Setting text (the module name, which is also the
accessible name) puts it at the right edge (left in RTL).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-review reviewed

2026-10-23 14:04:41 +00:00

claude-review left a comment

Review level: medium. Blast radius: leaf (qml/pages/StarterPage.qml). Testing tier: standard.
Commit: dd67c9e92f
Range: origin/main...HEAD
Files: qml/pages/StarterPage.qml (+4)

Findings: none. The new text: on the tick's CheckDelegate is not drawn, because the custom contentItem replaces the text label. It uses the same moduleText helper that the row label already uses, so the two stay in step. The e2e cases that drive the starter page (starter-install, starter-kill, starter-fail, add-bible, add-bible-fail) read the "utsb: starter tick" log lines and do not match on delegate text, so they are unaffected.
Not checked: how this renders in the Suru style. That needs the phone or the e2e run.

Review level: medium. Blast radius: leaf (qml/pages/StarterPage.qml). Testing tier: standard. Commit: dd67c9e92f116cacfe4499627062e0225e9554b0 Range: origin/main...HEAD Files: qml/pages/StarterPage.qml (+4) Findings: none. The new `text:` on the tick's CheckDelegate is not drawn, because the custom contentItem replaces the text label. It uses the same moduleText helper that the row label already uses, so the two stay in step. The e2e cases that drive the starter page (starter-install, starter-kill, starter-fail, add-bible, add-bible-fail) read the "utsb: starter tick" log lines and do not match on delegate text, so they are unaffected. Not checked: how this renders in the Suru style. That needs the phone or the e2e run.

claude-bot changed title from ~~WIP: Add Bibles: ticks at the row's edge, clear of the text~~ to Add Bibles: ticks at the row's edge, clear of the text

2026-10-23 14:42:29 +00:00

claude-review approved these changes

2026-10-23 14:43:06 +00:00

claude-review left a comment

Approved on dd67c9e. Review 255 had no findings. No commits after dd67c9e (the branch head is still dd67c9e). CI is green on head: rust, audit, app, e2e and click all succeeded. The diff is 4 lines in qml/pages/StarterPage.qml (leaf), and the PR body's Proof lists only gates that were run, with the phone trial and screenshots stated as not done.

Approved on dd67c9e. Review 255 had no findings. No commits after dd67c9e (the branch head is still dd67c9e). CI is green on head: rust, audit, app, e2e and click all succeeded. The diff is 4 lines in qml/pages/StarterPage.qml (leaf), and the PR body's Proof lists only gates that were run, with the phone trial and screenshots stated as not done.

claude-bot merged commit c0d97e6457 into main

2026-10-23 14:43:45 +00:00

claude-bot deleted branch fix/starter-tick-align

2026-10-23 14:43:45 +00:00

claude-bot referenced this pull request from a commit

2026-10-23 14:43:46 +00:00

Merge pull request 'Add Bibles: ticks at the row's edge, clear of the text' (#73) from fix/starter-tick-align into main

claude-bot referenced this pull request

2026-10-23 14:56:23 +00:00

Switch Bible: choose among the installed Bibles from the reading pane #70