History: Session::back pops and re-pushes skipped entries in separate transactions #69

New issue

Closed

opened 2026-10-22 20:18:11 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-10-22 20:18:11 +00:00

Collaborator

Follow-up from #27's gate (low), noted on #11.

Session::back pops history entries that belong to another Bible and re-pushes them in a separate transaction. A kill between the two loses those entries, which breaks the CLAUDE.md rule that the app can be killed at any moment.

Fix: do the pop and the re-push in one transaction, and add a test that fails without it (for example, an error injected between the two steps leaves the stack unchanged).

Follow-up from #27's gate (low), noted on #11. `Session::back` pops history entries that belong to another Bible and re-pushes them in a separate transaction. A kill between the two loses those entries, which breaks the CLAUDE.md rule that the app can be killed at any moment. Fix: do the pop and the re-push in one transaction, and add a test that fails without it (for example, an error injected between the two steps leaves the stack unchanged).

claude-bot added this to the v0.1 — reader milestone

2026-10-22 20:18:11 +00:00

claude-bot added the

priority

Should

label

2026-10-22 20:18:11 +00:00

schaefera referenced this issue from a commit

2026-10-29 15:45:31 +00:00

History: peek and drop an entry instead of pop (#69)

schaefera referenced this issue from a commit

2026-10-29 15:45:31 +00:00

Back: drop the entry only once it is placed, no re-push (#69)

claude-bot referenced this issue from a pull request that will close it,

2026-10-29 15:45:42 +00:00

Back: do not lose a history entry on a kill or failed write (#69) #120

claude-bot closed this issue

2026-10-29 16:11:57 +00:00

claude-bot referenced this issue from a commit

2026-10-29 16:11:57 +00:00

Merge pull request 'Back: do not lose a history entry on a kill or failed write (#69)' (#120) from fix/back-one-transaction into main

claude-bot commented

2026-10-29 16:13:11 +00:00

Author

Collaborator

Fixed by #120 (merged). I checked it on the phone on the PR build 89a9113 (PR comment 2420): Go to John 3:16, then Rom 8:28, then Back went to John 3:16. A kill and relaunch restored it, and Back again went to Matt 23:3. The change is invisible in use, so there is nothing for the owner to sign off.

🤖 Generated with Claude Code

Fixed by #120 (merged). I checked it on the phone on the PR build 89a9113 (PR comment 2420): Go to John 3:16, then Rom 8:28, then Back went to John 3:16. A kill and relaunch restored it, and Back again went to Matt 23:3. The change is invisible in use, so there is nothing for the owner to sign off. 🤖 Generated with [Claude Code](https://claude.com/claude-code)