Modules: warn about known flaws in a module (ASV: glued words at added words) #127

New issue

Open

opened 2026-10-29 19:38:46 +00:00 by claude-bot · 2 comments

claude-bot commented

2026-10-29 19:38:46 +00:00

Collaborator

Seen on the phone while checking #126, in an earlier shot of ASV Ps 119:128 (running text): "Therefore I esteem allthyprecepts concerning allthingsto be right; AndI hate every false way."

Cause: the module's own markup has no whitespace around its <transChange type="added"> words:

<w lemma="strong:H3605">all</w><transChange type="added">thy</transChange><w lemma="strong:H6490">precepts</w>
… <transChange type="added"><w lemma="strong:H3605">And</w></transChange><w lemma="strong:H3651">I</w>

The filter passes transChange through without special handling, on main as well as on #126, so this isn't a regression. diatheke's plain output should be glued the same way (to confirm with tools/golden).

Owner decision:

(a) Report it to CrossWire as a module bug, and leave the text as the module gives it, per the "module output must match the module" rule.
(b) Add a narrow fix: insert a space at a transChange edge when both sides are letters with no space between them. This would need its own golden exception, and a check that no other module (KJV uses transChange heavily) relies on the gluing, for example for word parts.

Added words could also be shown in italics, as printed Bibles do. That is a separate feature.

🤖 Generated with Claude Code

Seen on the phone while checking #126, in an earlier shot of ASV Ps 119:128 (running text): "Therefore I esteem allthyprecepts concerning allthingsto be right; AndI hate every false way." **Cause:** the module's own markup has no whitespace around its `<transChange type="added">` words: ``` <w lemma="strong:H3605">all</w><transChange type="added">thy</transChange><w lemma="strong:H6490">precepts</w> … <transChange type="added"><w lemma="strong:H3605">And</w></transChange><w lemma="strong:H3651">I</w> ``` The filter passes transChange through without special handling, on main as well as on #126, so this isn't a regression. diatheke's plain output should be glued the same way (to confirm with `tools/golden`). **Owner decision:** - (a) Report it to CrossWire as a module bug, and leave the text as the module gives it, per the "module output must match the module" rule. - (b) Add a narrow fix: insert a space at a transChange edge when both sides are letters with no space between them. This would need its own golden exception, and a check that no other module (KJV uses transChange heavily) relies on the gluing, for example for word parts. Added words could also be shown in italics, as printed Bibles do. That is a separate feature. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added this to the v0.2 — study tools milestone

2026-10-29 19:38:46 +00:00

claude-bot added the

labels

2026-10-29 19:38:46 +00:00

claude-bot changed title from ~~ASV: words glued at added words ("allthyprecepts", "AndI")~~ to Modules: warn about known flaws in a module (ASV: glued words at added words)

2026-10-29 19:41:17 +00:00

claude-bot commented

2026-10-29 19:41:17 +00:00

Author

Collaborator

Owner decision: don't change ASV's text. Either leave it alone, or show a warning sign on it saying the module has some imperfections.

So no text heuristic (option b is dropped), and the text keeps matching the module. The issue is now:

A small list of known module flaws, kept with the app (for example next to presets/), keyed by module name with one short line each. ASV's line would be something like "Some words run together where the translators added words."
A warning sign on that module's row in Modules, opening that line. It shows whether the module is installed or not, so you know before you download it.
Optionally the same sign in the Bible chooser.
Reporting the flaw to CrossWire is still worth doing, so the list can shrink.

Still v0.2, Could.

🤖 Generated with Claude Code

**Owner decision:** don't change ASV's text. Either leave it alone, or show a warning sign on it saying the module has some imperfections. So no text heuristic (option b is dropped), and the text keeps matching the module. The issue is now: - A small list of known module flaws, kept with the app (for example next to `presets/`), keyed by module name with one short line each. ASV's line would be something like "Some words run together where the translators added words." - A warning sign on that module's row in Modules, opening that line. It shows whether the module is installed or not, so you know before you download it. - Optionally the same sign in the Bible chooser. - Reporting the flaw to CrossWire is still worth doing, so the list can shrink. Still v0.2, Could. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot commented

2026-10-29 19:42:45 +00:00

Author

Collaborator

On the CrossWire report in the last comment: the owner writes or signs off any message to CrossWire. Whoever picks this up drafts it here and does not send it.

🤖 Generated with Claude Code

On the CrossWire report in the last comment: the owner writes or signs off any message to CrossWire. Whoever picks this up drafts it here and does not send it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot referenced this issue

2026-11-03 21:37:20 +00:00

ASV: words run together around added words (transChange) — "allthyprecepts", "AndI" #119