schaefera/feedsignal
Watch
1
0
Fork
You've already forked feedsignal
 0
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions

ci: run feedsignal-web tests, map blast radius #13

Open
claude-bot wants to merge 2 commits from chore/agentic-review-workflow into main
pull from: chore/agentic-review-workflow
merge into: schaefera:main
Conversation 0 Commits 2 Files changed 4 +70 -3
claude-bot commented 2026-10-12 13:16:51 +00:00
Collaborator

What

CI now also runs cargo test -p feedsignal-web --no-default-features --features server. The workspace test run skips feedsignal-web, because its default feature is the wasm client, so its server tests never ran in CI. DEFINITION_OF_DONE lists both commands.
Also adds a new CLAUDE.md with ## Blast radius and .forgejo/pull_request_template.md for the shipping-a-pr skill.

Blast radius

Tier: trunk (.forgejo/workflows/)
Trunk paths touched: .forgejo/workflows/ci.yml (one added step)
Gate / rollback: revert the step.

Proof

  • Run locally: cargo test -p feedsignal-web --no-default-features --features server passes 10 tests.
  • The feature set matches the existing native clippy step, and the reviewer confirmed there are #[test]s in crates/web/src/app/*/handlers.rs.
  • Not yet run on the Forgejo runner. This PR's own CI run is the first real run.

Review

Reviewer: fresh-context Sonnet review at medium, batched across all 8 rollout repos. No findings for this repo.
Review-Confidence: 75/100. Held down because workflows are trunk and were reviewed at medium rather than high, and the step hasn't run on the runner.

Confidence by part

  • New CI step: high. It's the same command that passed locally.
  • Not in this PR: the README is stale.

🤖 Generated with Claude Code

## What CI now also runs `cargo test -p feedsignal-web --no-default-features --features server`. The workspace test run skips feedsignal-web, because its default feature is the wasm client, so its server tests never ran in CI. DEFINITION_OF_DONE lists both commands. Also adds a new CLAUDE.md with `## Blast radius` and `.forgejo/pull_request_template.md` for the `shipping-a-pr` skill. ## Blast radius **Tier:** trunk (`.forgejo/workflows/`) **Trunk paths touched:** `.forgejo/workflows/ci.yml` (one added step) **Gate / rollback:** revert the step. ## Proof - Run locally: `cargo test -p feedsignal-web --no-default-features --features server` passes 10 tests. - The feature set matches the existing native clippy step, and the reviewer confirmed there are `#[test]`s in `crates/web/src/app/*/handlers.rs`. - **Not yet run on the Forgejo runner.** This PR's own CI run is the first real run. ## Review **Reviewer:** fresh-context Sonnet review at medium, batched across all 8 rollout repos. No findings for this repo. **Review-Confidence:** 75/100. Held down because workflows are trunk and were reviewed at medium rather than high, and the step hasn't run on the runner. ## Confidence by part - New CI step: high. It's the same command that passed locally. - Not in this PR: the README is stale. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
CLAUDE.md gains a Blast radius section (trunk paths, gate/rollback convention, expected proof) that the shipping-a-pr skill uses to pick review depth; the PR template has slots for tier, rollback, proof, review score and per-part confidence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci: run feedsignal-web's tests
All checks were successful
CI / check (pull_request) Successful in 11m33s
Details
CI / test (pull_request) Successful in 8m21s
Details
CI / audit (pull_request) Successful in 11s
Details
5824978374 
The workspace test step excludes feedsignal-web, so its handler tests never ran in CI. Run them under the server feature set, and update the Definition of Done to match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review-Confidence: 75
Review-Tier: trunk
Some checks are pending
CI / check (pull_request) Successful in 11m33s
Required
Details
CI / test (pull_request) Successful in 8m21s
Required
Details
CI / audit (pull_request) Successful in 11s
Required
Details
CI / clippy-native (pull_request)
Required
CI / clippy-server (pull_request)
Required
CI / clippy-web (pull_request)
Required
CI / clippy-desktop (pull_request)
Required
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin "chore/agentic-review-workflow:chore/agentic-review-workflow"
git switch "chore/agentic-review-workflow"
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
schaefera/feedsignal!13
No description provided.