refactor(passcore): split entry changes out of lib.rs #4

Merged

schaefera merged 2 commits from split-passcore-lib into main 2026-10-05 12:25:28 +00:00

Conversation 1 Commits 2 Files changed 3 +684 -662

claude-bot commented 2026-10-05 10:58:12 +00:00

Collaborator

• Copy link
• Copy Markdown

Stacked on #3. Merge #3 first, then retarget this to main. The base is delete-rename so that the diff shows only the move.

passcore/src/lib.rs had grown to 977 lines covering two jobs: the store itself, and changing entries. This only moves code; nothing behaves differently.

• lib.rs (now 323 lines): store setup, .gpg-id and recipients, listing, decrypt and Decrypted, entry_path.
• entry.rs (new): Version, Change, EntryWrite, EntryRename, Store::write_entry / rename_entry / delete_entry with their helpers, and their tests. It is a child module, so it still uses Store's private fields directly.
• testutil.rs (new): the shared test helpers, previously an inline module in lib.rs, plus store_in / keyed_store, which both test modules now use.
• The public API is unchanged: everything moved is re-exported from the crate root, so the bridge doesn't change.

Checks:

• cargo make passes: 73 passcore tests, the same count as before the move.
• Coverage is unchanged at 92.21%.

🤖 Generated with Claude Code

**Stacked on #3.** Merge #3 first, then retarget this to `main`. The base is `delete-rename` so that the diff shows only the move. `passcore/src/lib.rs` had grown to 977 lines covering two jobs: the store itself, and changing entries. This only moves code; nothing behaves differently. - **`lib.rs`** (now 323 lines): store setup, `.gpg-id` and recipients, listing, `decrypt` and `Decrypted`, `entry_path`. - **`entry.rs`** (new): `Version`, `Change`, `EntryWrite`, `EntryRename`, `Store::write_entry` / `rename_entry` / `delete_entry` with their helpers, and their tests. It is a child module, so it still uses `Store`'s private fields directly. - **`testutil.rs`** (new): the shared test helpers, previously an inline module in `lib.rs`, plus `store_in` / `keyed_store`, which both test modules now use. - The public API is unchanged: everything moved is re-exported from the crate root, so the bridge doesn't change. Checks: - `cargo make` passes: 73 passcore tests, the same count as before the move. - Coverage is unchanged at 92.21%. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-05 10:58:13 +00:00

passcore: move entry changes to entry.rs, test helpers to testutil.rs ... 02416cb319

lib.rs keeps the store itself (setup, recipients, listing, decrypting);
entry.rs gets adding, editing, renaming and deleting with Version and
their tests. No behaviour change; the public API is re-exported as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

schaefera added 7 commits 2026-10-05 12:07:54 +00:00

CI: use glibc's gettext, cache the cargo registry where it is ... 98868bda63

gettext-sys built GNU gettext from source (./configure && make) for
every profile: ~8 min each in the clippy and release-check steps,
which sccache can't cache. glibc has gettext built in, on the desktop,
the CI image and the phone alike, so use it (gettext-system).

The registry cache pointed at ~/.cargo, but CARGO_HOME is
/usr/local/cargo in the rust image, so it was never saved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge pull request 'feat: rename and delete entries' (#3) from delete-rename into main ... 05ee4e9980

Reviewed-on: #3
Reviewed-by: Austin Schaefer <austin.schaefer@mailo.eu>

CI: link the image's OpenSSL instead of building the vendored one ... aaa23f7dff

git2's vendored-openssl builds OpenSSL with Configure && make, which
sccache can't cache: about 8 of the 14 minutes left in run 24, over
the three builds. OPENSSL_NO_VENDOR makes openssl-sys use the system
library instead; the phone package still vendors it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

CI: key the sccache cache on Cargo.toml and the workflow too ... 92907d5447

actions/cache never saves over an existing key, so with a key on
Cargo.lock alone the cache stayed as first saved: run 26 missed 27%
of compiles (every crate the gettext feature or OPENSSL_NO_VENDOR
touches) and would on every run until Cargo.lock changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge branch 'main' into ci-speedup bb6ba0f98e

Merge pull request 'ci: stop building GNU gettext from source; fix the registry cache' (#5) from ci-speedup into main ... 5763d24654

Reviewed-on: #5
Reviewed-by: Austin Schaefer <austin.schaefer@mailo.eu>

Merge branch 'main' into split-passcore-lib ... d4c24b76a7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

schaefera changed target branch from delete-rename to main 2026-10-05 12:16:23 +00:00

schaefera approved these changes 2026-10-05 12:16:33 +00:00

schaefera merged commit 269ea24a16 into main 2026-10-05 12:25:28 +00:00

schaefera referenced this pull request from a commit 2026-10-05 12:25:29 +00:00

Merge pull request 'refactor(passcore): split entry changes out of lib.rs' (#4) from split-passcore-lib into main

Sign in to join this conversation.

Reviewers

No reviewers

schaefera

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

schaefera/TouchPass!4

No description provided.