Austin Schaefer

schaefera merged pull request schaefera/feedsignal#4

2026-09-03 11:17:16 +00:00

Split web crate into layered modules (api/services/jobs/view)

schaefera created branch worktree-srp-refactor-web in schaefera/feedsignal

2026-09-03 10:03:25 +00:00

schaefera pushed to worktree-srp-refactor-web at schaefera/feedsignal

2026-09-03 10:03:25 +00:00

44b9724645 Split web crate into layered modules (api/services/jobs/view)

schaefera pushed to worktree-pkgbuild-packaging at schaefera/doubleo7

2026-08-24 11:42:24 +00:00

fa4b78a7e0 fix: add cmake to PKGBUILD makedepends

schaefera created branch worktree-pkgbuild-packaging in schaefera/doubleo7

2026-08-24 10:18:38 +00:00

schaefera pushed to worktree-pkgbuild-packaging at schaefera/doubleo7

2026-08-24 10:18:38 +00:00

b0ebe933d3 Add PKGBUILD for local Arch/Manjaro install

schaefera approved schaefera/feedsignal#3

2026-08-21 14:54:05 +00:00

Add manual feed subscription

lgtm

schaefera pushed to worktree-manual-feed-subscribe at schaefera/feedsignal

2026-08-21 13:41:19 +00:00

f28ed7b758 Fix CI: cargo fmt and clippy -D warnings failures

schaefera pushed to worktree-manual-feed-subscribe at schaefera/feedsignal

2026-08-21 13:38:54 +00:00

e621720e47 Split has_content test into three cases per reviewer request

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:37:59 +00:00

Add manual feed subscription

Make three separate unit tests instead of one so we know which case breaks if a regression occurs.

schaefera pushed to worktree-manual-feed-subscribe at schaefera/feedsignal

2026-08-21 13:32:43 +00:00

8d316408b8 Address review feedback on manual feed subscription

schaefera suggested changes for schaefera/feedsignal#3

2026-08-21 13:29:42 +00:00

Add manual feed subscription

Some aspects are unclear to me.

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:28:41 +00:00

Add manual feed subscription

What if the url is correctly formed but otherwise points to nothing or a feed which no longer exists? Is this case handled?

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:27:55 +00:00

Add manual feed subscription

Wouldn't this make sense before the trim with a is_blank() style check? Aka check if it's not just pure whitespace?

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:26:09 +00:00

Add manual feed subscription

This feels pseudo duplicated compared to some of the earlier code. What is the reason for both subscription-centric methods existing, just for my own understanding?

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:23:45 +00:00

Add manual feed subscription

Any way to invert this logic so the check is positive instead of negative? Would help grok it faster. Not major either way.

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:21:46 +00:00

Add manual feed subscription

Good guard, would be also nice if the submit button wasn't clickable if the feed_url text box was empty

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:21:07 +00:00

Add manual feed subscription

Rename to feed_title for clarity of purpose

schaefera commented on pull request schaefera/feedsignal#3

2026-08-21 13:21:02 +00:00

Add manual feed subscription

Would indicate ev's type here for clarity as well

schaefera created branch worktree-manual-feed-subscribe in schaefera/feedsignal

2026-08-21 13:16:01 +00:00