Add feed sidebar navigation #8

Merged

schaefera merged 14 commits from worktree-feed-sidebar-nav into main 2026-09-15 07:20:41 +00:00

Conversation 0 Commits 14 Files changed 42 +2949 -91

claude-bot commented 2026-09-03 17:44:42 +00:00

Collaborator

Copy link

Summary

• Adds a sidebar listing subscribed feeds for navigation/filtering, built with dioxus-primitives components (Sidebar, Button, Badge, ScrollArea, etc.) rather than raw elements
• Default view stays the "all joined" article list; selecting a feed filters server-side via list_ranked_articles(feed_id)
• Adds db::articles unit tests covering the new feed_id filter (no filter / filter / score ordering)

Fixes along the way

• Article row layout: "Not relevant" button overlapping the title, uneven spacing from empty summaries
• Subscribe button overflowing the sidebar's fixed width (root cause: #[css_module] class hashing made a handwritten selector target nothing)
• Article list not scrolling (root cause: a duplicate <main> wrapper inside SidebarInset, which already renders its own <main>)

Test plan

• cargo test --workspace --exclude feedsignal-web
• cargo clippy (server + web + wasm feature sets) clean
• cargo fmt --check
• Manually verified against a live dx serve instance: feed switching, subscribe form, article row layout, and list scrolling all confirmed via DOM inspection, not just visually

## Summary - Adds a sidebar listing subscribed feeds for navigation/filtering, built with `dioxus-primitives` components (Sidebar, Button, Badge, ScrollArea, etc.) rather than raw elements - Default view stays the "all joined" article list; selecting a feed filters server-side via `list_ranked_articles(feed_id)` - Adds `db::articles` unit tests covering the new `feed_id` filter (no filter / filter / score ordering) ## Fixes along the way - Article row layout: "Not relevant" button overlapping the title, uneven spacing from empty summaries - Subscribe button overflowing the sidebar's fixed width (root cause: `#[css_module]` class hashing made a handwritten selector target nothing) - Article list not scrolling (root cause: a duplicate `<main>` wrapper inside `SidebarInset`, which already renders its own `<main>`) ## Test plan - [x] `cargo test --workspace --exclude feedsignal-web` - [x] `cargo clippy` (server + web + wasm feature sets) clean - [x] `cargo fmt --check` - [x] Manually verified against a live `dx serve` instance: feed switching, subscribe form, article row layout, and list scrolling all confirmed via DOM inspection, not just visually

claude-bot added 6 commits 2026-09-03 17:44:43 +00:00

Add feed sidebar navigation, built from Dioxus's component library ... 6a2bf8c9a8

Default view stays the all-feeds joined article list, now with a sidebar
listing every subscribed feed so a reader can pin down to one feed's
articles. Filtering happens server-side (list_ranked_articles now takes
an optional feed_id).

Pulled in the sidebar/badge/scroll_area (plus their sheet/skeleton/
tooltip/separator dependencies) components via `dx components add`
instead of hand-rolling nav/tag/scroll markup, matching this project's
existing pattern of using the Dioxus component library over raw
elements (see button/input).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

Add unit tests for list_ranked_articles' feed_id filtering ... 8edffe8973

The sidebar's per-feed nav depends on this query correctly scoping to
one feed (or joining all of them when feed_id is None), and it's real
branching logic rather than a passthrough — exactly what the updated
Definition of Done's testing rule calls for.

Uses a throwaway SQLite file per test (migrated fresh, cleaned up via
Drop) rather than a shared fixture, since diesel-async's bb8 pool would
otherwise hand out per-connection ":memory:" databases that don't share
state.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

Fix article row layout: button overlapping title, uneven summary gaps ... 21103b1f25

article-row had no layout structure at all — title link, score badge,
and the dismiss button were plain inline siblings in a block <li>, so a
long title pushed the button flush against (or past) the row's edge.
Group title+score into a header row and make the row itself a flex
column so summary/topics/button always stack on their own line below,
regardless of title length.

Also stopped rendering the summary <p> and topics div at all when
there's no content (many RSS entries have no description), instead of
emitting empty elements — spacing was uneven because those still
reserved a line's worth of height. Left this as an explicit Rust-side
branch rather than CSS :empty: an empty <p> still contains a
zero-length text node, and whether :empty matches that is
inconsistent across engines, whereas the topics div (an empty `for`
loop) has zero children and would be a safe :empty candidate — but
kept both on the same explicit mechanism for consistency.

Swapped the dismiss button from a raw <button> to the dx Button
component, matching the rest of the row and the project's preference
for the component library over raw elements.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

Fix Subscribe button overflowing the sidebar's fixed width ... 86863d809d

Not an article-row or hot-reload issue after all — the Subscribe
button in the sidebar header was genuinely spilling past the sidebar's
16rem width into the main content column. The sidebar panel is
position: fixed; z-index: 10 (dx-sidebar-container in the vendored
sidebar CSS), so that overflow floated on top of whatever main content
happened to sit at the same height, which was the first article row's
button — hence it only ever looked broken there.

Root cause: .subscribe-form .dx-input had flex: 1 but no min-width: 0,
so flexbox's default min-width: auto stopped it shrinking below its
content-based minimum once the Subscribe button took its share of the
row — a classic flexbox overflow gotcha. Added min-width: 0 to both
the input and the form row.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

Actually fix the Subscribe button overflow (previous fix was inert) ... 44e2fb4d4e

The prior commit's .subscribe-form .dx-input selector never matched
anything: dioxus's #[css_module] macro content-hashes Input's class at
build time (e.g. rendered as class="dx-input-83f82cbc", confirmed by
inspecting the live DOM), so a selector on the unhashed "dx-input"
name was dead CSS from the start — hence the overflow persisting
across rebuilds and hard refreshes.

Select on the raw <input> tag within .subscribe-form instead, which
doesn't depend on the module's per-build hash. Verified against the
running dev server (not just visually): the Subscribe button now
renders flush with the form's own right edge (both at x=247) instead
of spilling to x=314, well inside the sidebar's x=256 boundary.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

Fix article list not scrolling: duplicate <main> broke the scroll area ... f0e42e2ad5

Articles past the first screenful were unreachable — not clipped by
accident, genuinely inaccessible, since the page itself couldn't
scroll either (the sidebar wrapper is overflow: hidden by design, so
the intended scroll boundary is internal to the main content pane).

Root cause: SidebarInset already renders a <main> (class
dx-sidebar-inset, a properly height-bound flex column — main{
height:900px in a 900px viewport, flex-direction:column}), but I'd
also written an explicit `main { ... }` as ITS child, producing a
`<main><main>...</main></main>` (confirmed via a headless Playwright
probe against the live dev server, not just DevTools guesswork). The
inner <main> is just a plain flex item with the default flex: 0 1 auto,
so it sized to its own content (6500+px) instead of being constrained
by the outer one's box, and the ScrollArea inside it had nothing
bounded to scroll within.

Removed the redundant inner <main> — SidebarInset's children (the
content-header div and ScrollArea) now sit directly in its own <main>,
which is the actual flex column that needs to size them. Also pinned
ScrollArea's direction to Vertical (it defaults to Both, which was
adding an unnecessary horizontal scrollbar) and moved the sizing rule
in app.css off a class ScrollArea silently drops (confirmed via the
same probe — a caller-supplied `class` never reaches ScrollArea's
rendered DOM, only its own internal one does) onto its stable
data-scroll-direction attribute instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

schaefera added 1 commit 2026-09-03 17:49:43 +00:00

Merge list_feeds_with_titles into list_feeds ... 33d2dfe011

Both queried the same table with near-identical loads, differing only
by an extra title column and ordering. Fold title into list_feeds'
tuple (its one prior caller, the polling job, ignores it) so there's
a single feed-listing query instead of two that can drift apart.

schaefera added 1 commit 2026-09-03 19:20:46 +00:00

Turn RankedArticleRow into a struct instead of a 7-field tuple ... 73c80491be

Tuples this large stop being readable at the call site (positional
indices like rows[0].6 give no hint what they mean); a named struct
documents each field and lets rustc catch reordering mistakes.

schaefera added 2 commits 2026-09-03 19:23:39 +00:00

Merge main to pick up Definition of Done f4b7e95d15

Add and apply a models.rs convention for data-model structs ... e70909af47

Document in the DoD that data-model structs (domain models, query row
types, DTOs/views) belong in a crate's models.rs rather than the file
that produces/consumes them, once used outside that function -
matching the existing crates/core/src/models.rs pattern. Component-
local structs (Props, Styles, context) are exempt.

Apply it to db: move RankedArticleRow out of articles.rs into a new
crates/db/src/models.rs.

schaefera added 1 commit 2026-09-03 19:27:00 +00:00

Decode list_ranked_articles rows via a From<Row> impl ... cc79f59a7d

Replaces the inline .map() closure with From<Row> for
RankedArticleRow, separating "what a raw SQLite row looks like" from
the query itself.

schaefera added 1 commit 2026-09-03 21:24:38 +00:00

Sweep dto.rs and RelevanceInputs into the models.rs convention ... 7ccc36955a

- crates/web/src/api/dto.rs -> api/models.rs (ArticleView/FeedView were
  already models-shaped content, just not named models.rs)
- crates/core/src/scoring.rs's RelevanceInputs moves into
  crates/core/src/models.rs alongside the other core domain types,
  since it's built by score_article's callers, not score_article
  itself

Also picks up an unrelated fmt fix in db/src/articles.rs (import
ordering) that landed on disk from elsewhere.

schaefera added 1 commit 2026-09-03 21:24:51 +00:00

Move RelevanceInputs into core's models.rs, wire up api/models.rs rename ... 893e0ed251

The previous commit only carried the dto.rs -> models.rs file rename;
this carries the rest: mod.rs's import/re-export update, and
RelevanceInputs moving out of scoring.rs into models.rs (built by
score_article's callers, not score_article itself), plus an unrelated
import-order fmt fix in db/src/articles.rs.

schaefera added 1 commit 2026-09-15 07:16:32 +00:00

Let sidebar menu buttons grow with long feed titles ... 03a3c1577d

Fixed height + overflow:hidden on .dx-sidebar-menu-button caused long
feed titles (real RSS <title> text, often longer than the custom
labels shown in other readers) to clip and visually collide with the
next row. Switch to min-height per size variant and drop the
overflow/height clipping so rows grow to fit wrapped text; the
existing scrollable sidebar-content container handles the rest.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

schaefera merged commit de6b4578d4 into main 2026-09-15 07:20:41 +00:00

schaefera referenced this pull request from a commit 2026-09-15 07:20:43 +00:00

Merge pull request 'Add feed sidebar navigation' (#8) from worktree-feed-sidebar-nav into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: schaefera/feedsignal#8

No description provided.