worktree-definition-of-done #7

Merged

schaefera merged 2 commits from worktree-definition-of-done into main 2026-09-03 17:20:39 +00:00

Conversation 0 Commits 2 Files changed 1 +83

schaefera commented 2026-09-03 17:20:34 +00:00

Owner

Copy link

No description provided.

schaefera added 2 commits 2026-09-03 17:20:35 +00:00

Add Definition of Done ... 22d0e4f537

Codifies the quality bar already implicit in the CI gates and existing
code patterns (crate-boundary SRP, per-domain db modules, test comment
style) so it's explicit and reviewable rather than tribal knowledge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

Broaden Definition of Done testing rule beyond core ... 4846ab3bd6

Require unit tests for non-trivial logic project-wide (db query/filter
logic, non-passthrough server::services code), not just core's pure
functions, per feedback that the original scope was too narrow. Thin
passthrough wrappers stay exempt, and genuinely DB/network-bound cases
must be called out explicitly rather than silently skipped.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF

schaefera merged commit a37a93150b into main 2026-09-03 17:20:39 +00:00

schaefera referenced this pull request from a commit 2026-09-03 17:20:40 +00:00

Merge pull request 'worktree-definition-of-done' (#7) from worktree-definition-of-done into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: schaefera/feedsignal#7

No description provided.