Commit graph

3 commits

Author SHA1 Message Date
Austin Schaefer
e70909af47 Add and apply a models.rs convention for data-model structs
All checks were successful
CI / check (pull_request) Successful in 2m2s
CI / test (pull_request) Successful in 3m15s
CI / audit (pull_request) Successful in 10s
Document in the DoD that data-model structs (domain models, query row
types, DTOs/views) belong in a crate's models.rs rather than the file
that produces/consumes them, once used outside that function -
matching the existing crates/core/src/models.rs pattern. Component-
local structs (Props, Styles, context) are exempt.

Apply it to db: move RankedArticleRow out of articles.rs into a new
crates/db/src/models.rs.
2026-09-03 21:23:34 +02:00
Austin Schaefer
4846ab3bd6 Broaden Definition of Done testing rule beyond core
All checks were successful
CI / check (pull_request) Successful in 2m47s
CI / test (pull_request) Successful in 3m54s
CI / audit (pull_request) Successful in 14s
Require unit tests for non-trivial logic project-wide (db query/filter
logic, non-passthrough server::services code), not just core's pure
functions, per feedback that the original scope was too narrow. Thin
passthrough wrappers stay exempt, and genuinely DB/network-bound cases
must be called out explicitly rather than silently skipped.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF
2026-09-03 16:55:52 +02:00
Austin Schaefer
22d0e4f537 Add Definition of Done
Codifies the quality bar already implicit in the CI gates and existing
code patterns (crate-boundary SRP, per-domain db modules, test comment
style) so it's explicit and reviewable rather than tribal knowledge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqTJmazHBQK878vjQ4JnnF
2026-09-03 16:42:24 +02:00